RE: [PATCH v5 1/4] gpiolib: Pass bitmaps, not integer arrays, to get/set array

From: David Laight
Date: Thu Aug 30 2018 - 11:34:14 EST

From: Miguel Ojeda
> Sent: 30 August 2018 12:11
> > + unsigned long value_bitmap[1]; /* for DATA[0-7], RS, RW */
> (I read your comments in the other email)
> I still find this odd, but if everyone is going to have this change
> done like this, consistency is better.

Maybe there ought to be a define so you can do:
DEFINE_BITMAP(value_bitmap, 32);

While it might just generate an unsigned long [] there is probably
scope for stronger typing.


Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)