Re: [PATCH 2/6] staging: erofs: formatting fix to NULL comparison

From: Gao Xiang
Date: Thu Aug 30 2018 - 12:13:49 EST

Hi Pavel,

On 2018/8/30 23:13, Pavel Zemlyanoy wrote:
> This patch does not change the logic, it only
> corrects the formatting and checkpatch checks by
> to NULL comparison.
> The patch fixes 5 checks of type:
> "Comparison to NULL could be written".
> Signed-off-by: Pavel Zemlyanoy <zemlyanoy@xxxxxxxxx>

Sorry about the late reply. I am on vacation now.

Personally, I use "== NULL" or "!= NULL" on purpose, since it is more
emphasized than the suggested way, and I tend to use the nullptr explicitly.

BTW, It seems other filesystems still use "== NULL" or "!= NULL" explicitly, too, eg:
xfs, ext4, ext2, ocfs2, etc... You could 'grep' in the fs directory...

Other commits look good for me at glance.

Gao Xiang