RE: [PATCH v2] EDAC, ghes: use CPER module handles to locate DIMMs
From: wufan
Date: Thu Aug 30 2018 - 15:45:24 EST
Hi Tyler,
> > +static int get_dimm_smbios_index(u16 handle) {
> > + struct mem_ctl_info *mci;
> > + int i;
> > +
> > + mci = ghes_pvt->mci;
> > +
>
> Minor nit: you could define and set mci in the same line to save some space
> here.
>
> Otherwise this patch looks good to me.
Good catch Tyler! I'll fix it.
Thanks,
Fan
> Reviewed-by: Tyler Baicar <baicar.tyler@xxxxxxxxx>