Re: [PATCH] kconfig: remove a spurious self-assignment

[Masahiro Yamada]

2018-08-30 18:18 GMT+09:00 Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx>:
> The self assignment was probably introduced by an automated code
> refactoring in
> commit 694c49a7c01c ("kconfig: drop localization support").
>
> The issue was identified by a self-assign warning when running
> make menuconfig with clang.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx>
> ---

Applied to linux-kbuild/fixes. Thanks!


>  scripts/kconfig/mconf.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> index 83b5836..143c05f 100644
> --- a/scripts/kconfig/mconf.c
> +++ b/scripts/kconfig/mconf.c
> @@ -490,7 +490,6 @@ static void build_conf(struct menu *menu)
>                         switch (prop->type) {
>                         case P_MENU:
>                                 child_count++;
> -                               prompt = prompt;
>                                 if (single_menu_mode) {
>                                         item_make("%s%*c%s",
>                                                   menu->data ? "-->" : "++>",
> --
> 2.7.4
>



-- 
Best Regards
Masahiro Yamada