Re: [PATCH v2] gpio: brcmstb: allow 0 width GPIO banks

From: Gregory Fong
Date: Fri Aug 31 2018 - 17:26:32 EST


On Fri, Aug 17, 2018 at 4:48 PM <justinpopo6@xxxxxxxxx> wrote:
>
> From: Justin Chen <justinpopo6@xxxxxxxxx>
>
> Sometimes we have empty banks within the GPIO block. This commit allows
> proper handling of 0 width GPIO banks. We handle 0 width GPIO banks by
> incrementing the bank and number of GPIOs, but not initializing them.
> This will mean a call into the non-existent GPIOs will return an error.

This is clearer now; thanks for rewording!

>
> Also remove "GPIO registered" dev print. This information is misleading
> since the incremented banks and gpio_base do not reflect the actual GPIOs
> that get initialized. We leave this information out since it is already
> printed with dev_dbg.
>
> Signed-off-by: Justin Chen <justinpopo6@xxxxxxxxx>

Looks like I'm a bit late on the response, but in case you feel like
adding it Linus:

Acked-by: Gregory Fong <gregory.0xf0@xxxxxxxxx>