Re: [PATCH 3/7] Compiler Attributes: remove unneeded tests

From: kbuild test robot
Date: Sat Sep 01 2018 - 05:58:48 EST

Next message: Jia-Ju Bai: "[PATCH] net: scm: Fix a possible sleep-in-atomic-context bug in scm_fp_copy()"
Previous message: Luc Van Oostenryck: "Re: [PATCH 7/7] Compiler Attributes: use feature checks instead of version checks"
In reply to: kbuild test robot: "Re: [PATCH 3/7] Compiler Attributes: remove unneeded tests"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi Miguel,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.19-rc1 next-20180831]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Miguel-Ojeda/Compiler-Attributes-remove-unused-attributes/20180901-125644
config: sparc64-allnoconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=sparc64

Note: the linux-review/Miguel-Ojeda/Compiler-Attributes-remove-unused-attributes/20180901-125644 HEAD 4327b9ceea1b6be41cbce2c51370a365fc6a52cc builds fine.
It only hurts bisectibility.

All error/warnings (new ones prefixed by >>):

WARNING: unmet direct dependencies detected for COMPAT_BINFMT_ELF
Depends on COMPAT && BINFMT_ELF
Selected by
- COMPAT && SPARC64
In file included from include/linux/swab.h:5:0,
from include/uapi/linux/byteorder/big_endian.h:13,
from include/linux/byteorder/big_endian.h:5,
from arch/sparc/include/uapi/asm/byteorder.h:5,
from arch/sparc/include/asm/bitops_64.h:16,
from arch/sparc/include/asm/bitops.h:5,
from include/linux/bitops.h:19,
from include/linux/kernel.h:11,
from include/asm-generic/bug.h:18,
from arch/sparc/include/asm/bug.h:25,
from include/linux/bug.h:5,
from include/linux/page-flags.h:10,
from kernel/bounds.c:10:
include/uapi/linux/swab.h:47:15: error: unknown type name '__attribute_const__'
static inline __attribute_const__ __u16 __fswab16(__u16 val)
^~~~~~~~~~~~~~~~~~~
include/uapi/linux/swab.h:47:41: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__fswab16'
static inline __attribute_const__ __u16 __fswab16(__u16 val)
^~~~~~~~~
include/uapi/linux/swab.h:56:15: error: unknown type name '__attribute_const__'
static inline __attribute_const__ __u32 __fswab32(__u32 val)
^~~~~~~~~~~~~~~~~~~
include/uapi/linux/swab.h:56:41: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__fswab32'
static inline __attribute_const__ __u32 __fswab32(__u32 val)
^~~~~~~~~
include/uapi/linux/swab.h:65:15: error: unknown type name '__attribute_const__'
static inline __attribute_const__ __u64 __fswab64(__u64 val)
^~~~~~~~~~~~~~~~~~~
include/uapi/linux/swab.h:65:41: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__fswab64'
static inline __attribute_const__ __u64 __fswab64(__u64 val)
^~~~~~~~~
include/uapi/linux/swab.h:78:15: error: unknown type name '__attribute_const__'
static inline __attribute_const__ __u32 __fswahw32(__u32 val)
^~~~~~~~~~~~~~~~~~~
include/uapi/linux/swab.h:78:41: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__fswahw32'
static inline __attribute_const__ __u32 __fswahw32(__u32 val)
^~~~~~~~~~
include/uapi/linux/swab.h:87:15: error: unknown type name '__attribute_const__'
static inline __attribute_const__ __u32 __fswahb32(__u32 val)
^~~~~~~~~~~~~~~~~~~
include/uapi/linux/swab.h:87:41: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__fswahb32'
static inline __attribute_const__ __u32 __fswahb32(__u32 val)
^~~~~~~~~~
include/uapi/linux/swab.h: In function '__swahw32p':
>> include/uapi/linux/swab.h:144:2: error: implicit declaration of function '__fswahw32'; did you mean
__fswahw32(x))
^
include/uapi/linux/swab.h:207:9: note: in expansion of macro '__swahw32'
return
^~~~~~~~~
include/uapi/linux/swab.h: In function '__swahb32p':
>> include/uapi/linux/swab.h:155:2: error: implicit declaration of function '__fswahb32'; did you mean
__fswahb32(x))
^
include/uapi/linux/swab.h:222:9: note: in expansion of macro '__swahb32'
return
^~~~~~~~~
include/linux/byteorder/generic.h: In function 'le16_add_cpu':
>> include/uapi/linux/swab.h:106:2: error: implicit declaration of function '__fswab16'; did you mean
__fswab16(x))
^
include/uapi/linux/swab.h:104:32: note: in definition of macro '__swab16'
(__builtin_constant_p((__u16)(x)) ^
include/linux/byteorder/generic.h:90:21: note: in expansion of macro '__cpu_to_le16'
#define cpu_to_le16 __cpu_to_le16
^~~~~~~~~~~~~
include/uapi/linux/byteorder/big_endian.h:36:26: note: in expansion of macro '__swab16'
#define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x))
^~~~~~~~
include/linux/byteorder/generic.h:91:21: note: in expansion of macro '__le16_to_cpu'
#define le16_to_cpu __le16_to_cpu
^~~~~~~~~~~~~
>> include/linux/byteorder/generic.h:146:21: note: in expansion of macro 'le16_to_cpu'
= + val);
^~~~~~~~~~~
include/linux/byteorder/generic.h: In function 'le32_add_cpu':
>> include/uapi/linux/swab.h:119:2: error: implicit declaration of function '__fswab32'; did you mean
__fswab32(x))
^
include/uapi/linux/swab.h:117:32: note: in definition of macro '__swab32'
(__builtin_constant_p((__u32)(x)) ^
include/linux/byteorder/generic.h:88:21: note: in expansion of macro '__cpu_to_le32'
#define cpu_to_le32 __cpu_to_le32
^~~~~~~~~~~~~
include/uapi/linux/byteorder/big_endian.h:34:26: note: in expansion of macro '__swab32'
#define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x))
^~~~~~~~
include/linux/byteorder/generic.h:89:21: note: in expansion of macro '__le32_to_cpu'
#define le32_to_cpu __le32_to_cpu
^~~~~~~~~~~~~
>> include/linux/byteorder/generic.h:151:21: note: in expansion of macro 'le32_to_cpu'
= + val);
^~~~~~~~~~~
include/linux/byteorder/generic.h: In function 'le64_add_cpu':
>> include/uapi/linux/swab.h:132:2: error: implicit declaration of function '__fswab64'; did you mean
__fswab64(x))
^
include/uapi/linux/swab.h:130:32: note: in definition of macro '__swab64'
(__builtin_constant_p((__u64)(x)) ^
include/linux/byteorder/generic.h:86:21: note: in expansion of macro '__cpu_to_le64'
#define cpu_to_le64 __cpu_to_le64
^~~~~~~~~~~~~
include/uapi/linux/byteorder/big_endian.h:32:26: note: in expansion of macro '__swab64'
#define __le64_to_cpu(x) __swab64((__force __u64)(__le64)(x))
^~~~~~~~
include/linux/byteorder/generic.h:87:21: note: in expansion of macro '__le64_to_cpu'
#define le64_to_cpu __le64_to_cpu
^~~~~~~~~~~~~
>> include/linux/byteorder/generic.h:156:21: note: in expansion of macro 'le64_to_cpu'
= + val);
^~~~~~~~~~~
In file included from include/linux/kernel.h:12:0,
from include/asm-generic/bug.h:18,
from arch/sparc/include/asm/bug.h:25,
from include/linux/bug.h:5,
from include/linux/page-flags.h:10,
from kernel/bounds.c:10:
include/linux/log2.h: At top level:
include/linux/log2.h:202:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'int'
int __order_base_2(unsigned long n)
^~~
cc1: some warnings being treated as errors
Makefile Module.symvers System.map arch block built-in.a certs crypto drivers firmware fs include init ipc kernel lib mm modules.order net scripts security sound source usr virt vmlinux vmlinux.o Error 1
Target '__build' not remade because of errors.
Makefile Module.symvers System.map arch block built-in.a certs crypto drivers firmware fs include init ipc kernel lib mm modules.order net scripts security sound source usr virt vmlinux vmlinux.o Error 2
Target 'prepare' not remade because of errors.
make: Makefile Module.symvers System.map arch block built-in.a certs crypto drivers firmware fs include init ipc kernel lib mm modules.order net scripts security sound source usr virt vmlinux vmlinux.o Error 2

vim +/__fswahw32 +144 include/uapi/linux/swab.h

607ca46e David Howells 2012-10-13 86
607ca46e David Howells 2012-10-13 @87 static inline __attribute_const__ __u32 __fswahb32(__u32 val)
607ca46e David Howells 2012-10-13 88 {
607ca46e David Howells 2012-10-13 89 #ifdef __arch_swahb32
607ca46e David Howells 2012-10-13 90 return __arch_swahb32(val);
607ca46e David Howells 2012-10-13 91 #else
607ca46e David Howells 2012-10-13 92 return ___constant_swahb32(val);
607ca46e David Howells 2012-10-13 93 #endif
607ca46e David Howells 2012-10-13 94 }
607ca46e David Howells 2012-10-13 95
607ca46e David Howells 2012-10-13 96 /**
607ca46e David Howells 2012-10-13 97 * __swab16 - return a byteswapped 16-bit value
607ca46e David Howells 2012-10-13 98 * @x: value to byteswap
607ca46e David Howells 2012-10-13 99 */
7322dd75 Arnd Bergmann 2016-05-05 100 #ifdef __HAVE_BUILTIN_BSWAP16__
7322dd75 Arnd Bergmann 2016-05-05 101 #define __swab16(x) (__u16)__builtin_bswap16((__u16)(x))
7322dd75 Arnd Bergmann 2016-05-05 102 #else
607ca46e David Howells 2012-10-13 103 #define __swab16(x) \
607ca46e David Howells 2012-10-13 104 (__builtin_constant_p((__u16)(x)) ? \
607ca46e David Howells 2012-10-13 105 ___constant_swab16(x) : \
607ca46e David Howells 2012-10-13 @106 __fswab16(x))
7322dd75 Arnd Bergmann 2016-05-05 107 #endif
607ca46e David Howells 2012-10-13 108
607ca46e David Howells 2012-10-13 109 /**
607ca46e David Howells 2012-10-13 110 * __swab32 - return a byteswapped 32-bit value
607ca46e David Howells 2012-10-13 111 * @x: value to byteswap
607ca46e David Howells 2012-10-13 112 */
7322dd75 Arnd Bergmann 2016-05-05 113 #ifdef __HAVE_BUILTIN_BSWAP32__
7322dd75 Arnd Bergmann 2016-05-05 114 #define __swab32(x) (__u32)__builtin_bswap32((__u32)(x))
7322dd75 Arnd Bergmann 2016-05-05 115 #else
607ca46e David Howells 2012-10-13 116 #define __swab32(x) \
607ca46e David Howells 2012-10-13 117 (__builtin_constant_p((__u32)(x)) ? \
607ca46e David Howells 2012-10-13 118 ___constant_swab32(x) : \
607ca46e David Howells 2012-10-13 @119 __fswab32(x))
7322dd75 Arnd Bergmann 2016-05-05 120 #endif
607ca46e David Howells 2012-10-13 121
607ca46e David Howells 2012-10-13 122 /**
607ca46e David Howells 2012-10-13 123 * __swab64 - return a byteswapped 64-bit value
607ca46e David Howells 2012-10-13 124 * @x: value to byteswap
607ca46e David Howells 2012-10-13 125 */
7322dd75 Arnd Bergmann 2016-05-05 126 #ifdef __HAVE_BUILTIN_BSWAP64__
7322dd75 Arnd Bergmann 2016-05-05 127 #define __swab64(x) (__u64)__builtin_bswap64((__u64)(x))
7322dd75 Arnd Bergmann 2016-05-05 128 #else
607ca46e David Howells 2012-10-13 129 #define __swab64(x) \
607ca46e David Howells 2012-10-13 130 (__builtin_constant_p((__u64)(x)) ? \
607ca46e David Howells 2012-10-13 131 ___constant_swab64(x) : \
607ca46e David Howells 2012-10-13 @132 __fswab64(x))
7322dd75 Arnd Bergmann 2016-05-05 133 #endif
607ca46e David Howells 2012-10-13 134
607ca46e David Howells 2012-10-13 135 /**
607ca46e David Howells 2012-10-13 136 * __swahw32 - return a word-swapped 32-bit value
607ca46e David Howells 2012-10-13 137 * @x: value to wordswap
607ca46e David Howells 2012-10-13 138 *
607ca46e David Howells 2012-10-13 139 * __swahw32(0x12340000) is 0x00001234
607ca46e David Howells 2012-10-13 140 */
607ca46e David Howells 2012-10-13 141 #define __swahw32(x) \
607ca46e David Howells 2012-10-13 142 (__builtin_constant_p((__u32)(x)) ? \
607ca46e David Howells 2012-10-13 143 ___constant_swahw32(x) : \
607ca46e David Howells 2012-10-13 @144 __fswahw32(x))
607ca46e David Howells 2012-10-13 145
607ca46e David Howells 2012-10-13 146 /**
607ca46e David Howells 2012-10-13 147 * __swahb32 - return a high and low byte-swapped 32-bit value
607ca46e David Howells 2012-10-13 148 * @x: value to byteswap
607ca46e David Howells 2012-10-13 149 *
607ca46e David Howells 2012-10-13 150 * __swahb32(0x12345678) is 0x34127856
607ca46e David Howells 2012-10-13 151 */
607ca46e David Howells 2012-10-13 152 #define __swahb32(x) \
607ca46e David Howells 2012-10-13 153 (__builtin_constant_p((__u32)(x)) ? \
607ca46e David Howells 2012-10-13 154 ___constant_swahb32(x) : \
607ca46e David Howells 2012-10-13 @155 __fswahb32(x))
607ca46e David Howells 2012-10-13 156

:::::: The code at line 144 was first introduced by commit
:::::: 607ca46e97a1b6594b29647d98a32d545c24bdff UAPI: (Scripted) Disintegrate include/linux

:::::: TO: David Howells <dhowells@xxxxxxxxxx>
:::::: CC: David Howells <dhowells@xxxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip

Next message: Jia-Ju Bai: "[PATCH] net: scm: Fix a possible sleep-in-atomic-context bug in scm_fp_copy()"
Previous message: Luc Van Oostenryck: "Re: [PATCH 7/7] Compiler Attributes: use feature checks instead of version checks"
In reply to: kbuild test robot: "Re: [PATCH 3/7] Compiler Attributes: remove unneeded tests"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]