Re: [PATCH RFC LKMM 7/7] EXP tools/memory-model: Add .cfg and .cat files for s390

From: Paul E. McKenney
Date: Sat Sep 01 2018 - 13:10:29 EST


On Fri, Aug 31, 2018 at 05:06:30PM +0100, Will Deacon wrote:
> Hi Paul,
>
> On Wed, Aug 29, 2018 at 02:10:53PM -0700, Paul E. McKenney wrote:
> > This commit adds s390.cat and s390.cfg files to allow users to check
> > litmus tests for s390-specific code. Note that this change only enables
> > herd7 checking of C-language litmus tests. Larger changes are required
> > to enable the litmus7 and klitmus7 tools to check litmus tests on real
> > hardare.
> >
> > Suggested-by: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> > Suggested-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> > Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> > [ paulmck: Add fixes suggested by Alan Stern. ]
> > ---
> > tools/memory-model/s390.cat | 18 ++++++++++++++++++
> > tools/memory-model/s390.cfg | 21 +++++++++++++++++++++
> > 2 files changed, 39 insertions(+)
> > create mode 100644 tools/memory-model/s390.cat
> > create mode 100644 tools/memory-model/s390.cfg
>
> As I said before, I'd *much* prefer this to be part of the upstream
> herdtools7 repository. It's not really anything to do with the Linux
> kernel, so I don't think it belongs in the source tree.

Agreed. As the cover letter says, "Add .cfg and .cat files for s390,
which is a not-for-mainline placeholder."

Thanx, Paul