Re: [PATCH 1/4] staging: comedi: Correct multiline dereference as per TODO

[Ian Abbott]

On 30/08/18 18:32, Ray Clinton wrote:
> Using checkpatch.pl I was able to find a multiline dereference which goes
> again the coding style for the kernel. I'm still working on my email client so
> the indentation looks bad here (in gmail) but the arguments for
> comedi_check_trigger_arg_min should go just under the opening (

The patch description should describe what the patch does, not how bad 
the indentation loos in your email client.

> Signed-off-by: Ray Clinton <mr.ray.clinton@xxxxxxxxx>
> ---
>   drivers/staging/comedi/drivers/dt3000.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/dt3000.c
> b/drivers/staging/comedi/drivers/dt3000.c
> index 2edf3ee..6bc5c86 100644
> --- a/drivers/staging/comedi/drivers/dt3000.c
> +++ b/drivers/staging/comedi/drivers/dt3000.c
> @@ -439,9 +439,9 @@ static int dt3k_ai_cmdtest(struct comedi_device *dev,
>
>                  if (cmd->scan_begin_src == TRIG_TIMER) {
>                          arg = cmd->convert_arg * cmd->scan_end_arg;
> -                       err |= comedi_check_trigger_arg_min(&cmd->
> -                                                           scan_begin_arg,
> -                                                           arg);
> +                       err |= comedi_check_trigger_arg_min(
> +                                                          &cmd->scan_begin_arg,
> +                                                          arg);
>                  }
>          }
>
> --
> 2.7.4

I can't get the patch to apply.  Something is converting tabs to spaces, 
and I assume it is your email client doing that.  I recommend using the 
git send-email command to send the patches, after configuring your git 
to send emails via Gmail.  You can google how to do that, but here is a 
starting point: https://gist.github.com/jasonkarns/4354421

--
-=( Ian Abbott <abbotti@xxxxxxxxx> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268.  Registered address:    )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-