RE: [PATCH v3] EDAC, ghes: use CPER module handles to locate DIMMs

[wufan]

> -----Original Message-----
> From: Borislav Petkov <bp@xxxxxxxxx>
> Sent: Tuesday, September 4, 2018 1:29 AM
> To: Fan Wu <wufan@xxxxxxxxxxxxxx>
> Cc: mchehab@xxxxxxxxxx; james.morse@xxxxxxx; baicar.tyler@xxxxxxxxx;
> linux-edac@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; john.garry@xxxxxxxxxx; toshi.kani@xxxxxxx;
> tanxiaofei@xxxxxxxxxx; wanghuiqiang@xxxxxxxxxx;
> shiju.jose@xxxxxxxxxx
> Subject: Re: [PATCH v3] EDAC, ghes: use CPER module handles to locate
> DIMMs
> 
> On Tue, Sep 04, 2018 at 03:50:55AM +0000, Fan Wu wrote:
> > For platforms whose firmwares provide valid module handles (SMBIOS
> > type 17) in error records, this patch uses the module handles to
> > locate corresponding DIMMs and enables per-DIMM error counter update.
> >
> > Signed-off-by: Fan Wu <wufan@xxxxxxxxxxxxxx>
> > Reviewed-by: Tyler Baicar <baicar.tyler@xxxxxxxxx>
> > Tested-by: Toshi Kani <toshi.kani@xxxxxxx>
> 
> Those two tags I did see being given to you ...
> 
> > Reviewed-by: Borislav Petkov <bp@xxxxxxxxx>
> > Reviewed-by: James Morse <james.morse@xxxxxxx>
> > Reviewed-by: tanxiaofei <tanxiaofei@xxxxxxxxxx>
>
> ... but how in the world did you come up with those?

Sorry. Will remove these in v4. 
Thanks,
Fan

 
> Do you understand how Reviewed-by works or do you need to look at
> Documentation/process/submitting-patches.rst, section 13 ?
> 
> --
> Regards/Gruss,
>     Boris.
> 
> Good mailing practices for 400: avoid top-posting and trim the reply.