Re: [PATCH v2] ARM: dts: imx6ul: Add DTS for ConnectCore 6UL SBC Pro

[Fabio Estevam]

On Tue, Sep 4, 2018 at 12:28 PM, Alex Gonzalez <alex.gonzalez@xxxxxxxx> wrote:

> +&lcdif {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_lcdif_dat0_17
> +                    &pinctrl_lcdif_clken
> +                    &pinctrl_lcdif_hvsync>;
> +       lcd-supply = <&ldo4_ext>;       /* BU90T82 LVDS bridge power */
> +       status = "okay";

Missing a panel attached to the lcdif?

> +&pwm4 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_pwm4>;
> +       clocks = <&clks IMX6UL_CLK_PWM4>,
> +               <&clks IMX6UL_CLK_PWM4>;

Why do you need to pass the clocks here? imx6ul.dtsi already defines it.

> +       status = "okay";
> +};
> +
> +&pwm5 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_pwm5>;
> +       clocks = <&clks IMX6UL_CLK_PWM5>,
> +                <&clks IMX6UL_CLK_PWM5>;

Same here.

> +       pinctrl_sai2: sai2grp {
> +               fsl,pins = <
> +                       MX6UL_PAD_JTAG_TRST_B__SAI2_TX_DATA     0x11088
> +                       MX6UL_PAD_JTAG_TCK__SAI2_RX_DATA        0x11088
> +                       MX6UL_PAD_JTAG_TMS__SAI2_MCLK           0x17088
> +                       MX6UL_PAD_JTAG_TDI__SAI2_TX_BCLK        0x17088
> +                       MX6UL_PAD_JTAG_TDO__SAI2_TX_SYNC        0x17088
> +                       /* Interrupt */
> +                       MX6UL_PAD_SNVS_TAMPER7__GPIO5_IO07      0x80000000

Please do not use 0x80000000. Use the real IOMUX value instead.