Re: [PATCH] mmc: omap_hsmmc: fix wakeirq handling on removal

[Andreas Kemnade]

Hi,

On Tue, 4 Sep 2018 16:34:56 +0200
Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:

> On 2 September 2018 at 09:30, Andreas Kemnade <andreas@xxxxxxxxxxxx> wrote:
> > after unbinding mmc I get things like this:
> > [  185.294067] mmc1: card 0001 removed
> > [  185.305206] omap_hsmmc 480b4000.mmc: wake IRQ with no resume: -13
> >
> > The wakeirq stays in /proc-interrupts
> >
> > rebinding shows this:
> > [  289.795959] genirq: Flags mismatch irq 112. 0000200a (480b4000.mmc:wakeup) vs. 0000200a (480b4000.mmc:wakeup)
> > [  289.808959] omap_hsmmc 480b4000.mmc: Unable to request wake IRQ
> > [  289.815338] omap_hsmmc 480b4000.mmc: no SDIO IRQ support, falling back to polling
> >
> > That bug seems to be introduced by switching from devm_request_irq()
> > to generic wakeirq handling.
> >
> > So let us cleanup at removal.
> >
> > Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>
> > Fixes: 5b83b2234be6 ("mmc: omap_hsmmc: Change wake-up interrupt to use generic wakeirq")  
> 
> Applied for fixes, and added a stable tag, thanks!
> 
What also might be critical (still analyzing) of that patch I am fixing
is:
It keeps the wakeup irq also enabled when the sdio irq is disabled.

Regards,
Andreas

Attachment: pgpwsm9Ssq2ix.pgp
Description: OpenPGP digital signature