Re: [PATCH 1/4] HID: multitouch: fix Elan panels with 2 input modes declaration
From: Benjamin Tissoires
Date: Wed Sep 05 2018 - 03:01:29 EST
On Tue, Sep 4, 2018 at 9:31 PM Jiri Kosina <jikos@xxxxxxxxxx> wrote:
>
> On Tue, 4 Sep 2018, Benjamin Tissoires wrote:
>
> > When implementing commit 7f81c8db5489 ("HID: multitouch: simplify
> > the settings of the various features"), I wrongly removed a test
> > that made sure we never try to set the second InputMode feature
> > to something else than 0.
> >
> > This broke badly some recent Elan panels that now forget to send the
> > click button in some area of the touchpad.
> >
> > Fixes 7f81c8db5489
>
> Please make sure that the 'Fixes:' tag is always in proper format. There
> are tools depending on that :)
Oops, thanks for fixing it. Lazy me :)
Cheers,
Benjamin
>
> I'll fix that up manually.
>
> Thanks!
>
> --
> Jiri Kosina
> SUSE Labs
>