Re: [PATCH] ARM: dts: socfpga: use stdout-path for chosen node

[Geert Uytterhoeven]

On Wed, Aug 8, 2018 at 2:11 PM Marek Vasut <marex@xxxxxxx> wrote:
> On 08/08/2018 02:02 PM, Simon Goldschmidt wrote:
> > On Wed, Aug 8, 2018 at 1:32 PM Marek Vasut <marex@xxxxxxx> wrote:
> >> On 08/08/2018 11:09 AM, Simon Goldschmidt wrote:
> >>> Use stdout-path dts property for kernel console.
> >>>
> >>> There were two socfpga boards left not using stdout-path:
> >>> socrates and vining. Make sure they match the other boards.
> >>>
> >>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@xxxxxxxxx>
> >>> ---
> >>>  arch/arm/boot/dts/socfpga_cyclone5_socrates.dts    | 3 ++-
> >>>  arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts | 3 ++-
> >>>  2 files changed, 4 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_socrates.dts b/arch/arm/boot/dts/socfpga_cyclone5_socrates.dts
> >>> index 53bf99eef66d..6f5255a7d192 100644
> >>> --- a/arch/arm/boot/dts/socfpga_cyclone5_socrates.dts
> >>> +++ b/arch/arm/boot/dts/socfpga_cyclone5_socrates.dts
> >>> @@ -22,7 +22,8 @@
> >>>       compatible = "ebv,socrates", "altr,socfpga-cyclone5", "altr,socfpga";
> >>>
> >>>       chosen {
> >>> -             bootargs = "console=ttyS0,115200";
> >>> +             bootargs = "earlyprintk";
> >>> +             stdout-path = "serial0:115200n8";
> >>>       };
> >>>
> >>>       memory@0 {
> >>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts b/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts
> >>> index f50b19447de6..e61efe16e79c 100644
> >>> --- a/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts
> >>> +++ b/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts
> >>> @@ -54,7 +54,8 @@
> >>>       compatible = "samtec,vining", "altr,socfpga-cyclone5", "altr,socfpga";
> >>>
> >>>       chosen {
> >>> -             bootargs = "console=ttyS0,115200";
> >>> +             bootargs = "earlyprintk";
> >>
> >> Why this earlyprintk ?
> >
> > The reason is Dinh added that to all socfpga boards in his commit [1]
> > and I wanted the remaining two boards to be the same.
>
> Isn't earlyprintk mostly a debugging aid ?

Indeed.

And the modern way is "earlycon", not "earlyprintk".

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds