Re: [PATCH RT 21/22] Drivers: hv: vmbus: include header for get_irq_regs()

From: Steven Rostedt
Date: Wed Sep 05 2018 - 08:35:00 EST



[ It appears that quilt doesn't use the right mime for the strange
characters in the change log. I'm replying here as it was bounced
by the mailing lists ]

On Wed, 05 Sep 2018 08:28:15 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> 4.14.63-rt41-rc1 stable review patch.
> If anyone has any objections, please let me know.
>
> ------------------
>
> From: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
>
> [ Upstream commit b9fcc1867cc7921bb8441be327ed58461ed12255 ]
>
> On !RT the header file get_irq_regs() gets pulled in via other header files. On
> RT it does not and the build fails:
>
> drivers/hv/vmbus_drv.c:975 implicit declaration of function ÃÂÂget_irq_regsÃÂÂ [-Werror=implicit-function-declaration]
> drivers/hv/hv.c:115 implicit declaration of function ÃÂÂget_irq_regsÃÂÂ [-Werror=implicit-function-declaration]
>
> Add the header file for get_irq_regs() in a common header so it used by
> vmbus_drv.c by hv.c for their get_irq_regs() usage.
>
> Reported-by: Bernhard Landauer <oberon@xxxxxxxxxxx>
> Reported-by: Ralf Ramsauer <ralf.ramsauer@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
> ---
> drivers/hv/hyperv_vmbus.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h
> index 49569f8fe038..a3608cd52805 100644
> --- a/drivers/hv/hyperv_vmbus.h
> +++ b/drivers/hv/hyperv_vmbus.h
> @@ -30,6 +30,7 @@
> #include <linux/atomic.h>
> #include <linux/hyperv.h>
> #include <linux/interrupt.h>
> +#include <linux/irq.h>
>
> /*
> * Timeout for services such as KVP and fcopy.