Re: [PATCH V2 1/4] USB: serial: f81232: clear overrun flag

[Johan Hovold]

On Thu, Aug 30, 2018 at 09:47:10AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> The F81232 will report data and LSR with bulk like following format:
> bulk-in data: [LSR(1Byte)+DATA(1Byte)][LSR(1Byte)+DATA(1Byte)]...
> 
> LSR will auto clear frame/parity/break error flag when reading by H/W,
> but overrrun will only cleared when reading LSR. So this patch add a
> worker to read LSR when OE.
> 
> Cc: Oliver Neukum <oneukum@xxxxxxxx>
> Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@xxxxxxxxx>
> ---
> v2:
>         1: Add flush_work(&port_priv->lsr_work) in f81232_close().
>            Thanks for notice by Oliver Neukum

Looks like you ignored Oliver's comment that you needed to take care of
any pending lsr work both and close and suspend.

Johan