Re: [PATCH v8 4/8] media: platform: Add Cedrus VPU decoder driver

From: Paul Kocialkowski
Date: Wed Sep 05 2018 - 11:49:58 EST


Hi,

Le mardi 28 aoÃt 2018 Ã 22:08 -0300, Ezequiel Garcia a Ãcrit :
> On Tue, 2018-08-28 at 09:34 +0200, Paul Kocialkowski wrote:
> > +static const struct v4l2_m2m_ops cedrus_m2m_ops = {
> > + .device_run = cedrus_device_run,
> > + .job_abort = cedrus_job_abort,
> > +};
> > +
>
> I think you can get rid of this .job_abort. It should
> simplify your .device_run quite a bit.
>
> .job_abort is optional now since
> 5525b8314389a0c558d15464e86f438974b94e32.

Alright, I will probably do that for the next revision, since it seems
that there is no particular downside to removing it.

Thanks,

Paul

> Regards,
> Ezequiel

--
Developer of free digital technology and hardware support.

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/

Attachment: signature.asc
Description: This is a digitally signed message part