Re: [PATCHv2 1/1] perf/x86/intel: make error messages less confusing

From: Andi Kleen
Date: Wed Sep 05 2018 - 17:47:10 EST


On Wed, Sep 05, 2018 at 08:53:17AM -0700, Eduardo Valentin wrote:
> On Wed, Sep 05, 2018 at 10:52:12AM +0200, Peter Zijlstra wrote:
> > On Thu, Aug 23, 2018 at 08:07:32AM -0700, Eduardo Valentin wrote:
> > > On a system with X86_FEATURE_ARCH_PERFMON disabled
> > > and with a model not known by family PMU drivers,
> > > user gets a kernel message log like the following:
> > > [ 0.100114] Performance Events: unsupported p6 CPU model 85 no PMU driver, software events only.
> > >
> > > The "unsupported .. CPU" part may be confusing for some
> > > users leading to wrong understanding that the kernel
> > > does not support the CPU model.
> >
> > Send them back to first grade, such that they might learn to read?
> >
>
> :-)

I think it's a valid concern, I guess Eduardo actually has real people
who got confused.

-Andi