Re: [PATCH V3 19/26] dt-bindings: timer: gx6605s SOC timer

[Guo Ren]

On Wed, Sep 05, 2018 at 07:47:29PM -0500, Rob Herring wrote:
> On Wed, Sep 5, 2018 at 7:09 AM Guo Ren <ren_guo@xxxxxxxxx> wrote:
> >
> > Signed-off-by: Guo Ren <ren_guo@xxxxxxxxx>
> > ---
> >  .../bindings/timer/csky,gx6605s-timer.txt          | 46 ++++++++++++++++++++++
> >  1 file changed, 46 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/timer/csky,gx6605s-timer.txt
> >
> > diff --git a/Documentation/devicetree/bindings/timer/csky,gx6605s-timer.txt b/Documentation/devicetree/bindings/timer/csky,gx6605s-timer.txt
> > new file mode 100644
> > index 0000000..1136d9e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/timer/csky,gx6605s-timer.txt
> > @@ -0,0 +1,46 @@
> > +=================
> > +gx6605s SOC Timer
> > +=================
> > +
> > +The timer is used in gx6605s soc as system timer and the driver
> > +contain clk event and clk source.
> > +
> > +==============================
> > +timer node bindings definition
> > +==============================
> > +
> > +        Description: Describes gx6605s SOC timer
> > +
> > +        PROPERTIES
> > +
> > +        - compatible
> > +                Usage: required
> > +                Value type: <string>
> > +                Definition: must be "csky,gx6605s"
> 
> -timer?
Yes, thx. must be "csky,gx6605s-timer"
> 
> > +       - reg
> > +               Usage: required
> > +               Value type: <u32 u32>
> > +               Definition: <phyaddr size> in soc from cpu view
> > +       - clocks
> > +               Usage: required
> > +               Value type: <node>
> 
> phandle + clock specifier cells
Sorry, I don't got it. Do you mean:
                    Value type: <phandle + clock specifier cells>
?
> 
> > +               Definition: must be input clk node
> > +        - interrupt
> > +                Usage: required
> > +                Value type: <u32>
> > +                Definition: must be timer irq num defined by soc
> > +        - interrupt-parent:
> 
> This is implied. Don't need to document it here.
Ok, remove interrupt-parent
> 
> > +                Usage: required
> > +               Value type: <node>
> > +                Definition: must be interrupt controller node
> > +
> > +Examples:
> > +---------
> > +
> > +       timer:timer {
> 
> Needs a unit-address.
Ok, change to "timer0: timer@0x0020a000"
> 
> > +               compatible = "csky,gx6605s-timer";
> > +               reg = <0x0020a000 0x400>;
> > +               clocks = <&dummy_apb_clk>;
> > +               interrupts = <10>;
> > +               interrupt-parent = <&intc>;
> > +       };
> > --
> > 2.7.4
> >