Re: [PATCH v6 04/14] PM / EM: Expose the Energy Model in sysfs

From: Dietmar Eggemann
Date: Thu Sep 06 2018 - 02:57:29 EST


On 08/20/2018 02:44 AM, Quentin Perret wrote:
Expose the Energy Model (read-only) of all performance domains in sysfs
for convenience. To do so, add a kobject to the CPU subsystem under the
umbrella of which a kobject for each performance domain is attached.

The resulting hierarchy is as follows for a platform with two
performance domains for example:

/sys/devices/system/cpu/energy_model
âââ pd0
â âââ cost
â âââ cpus
â âââ frequency
â âââ power

cpus (cpumask of the perf domain), frequency (OPP's of the perf domain) and power (values at those OPP's) are somehow easy to grasp, cost is definitely not.

You have this nice description in em_pd_energy() what cost actually is. IMHO, might be worth repeating this at least in the patch header here.

[...]