Re: [PATCH 6/7] crypto: add sdmdev support to Hisilicon QM

[Kenneth Lee]

On Sun, Sep 02, 2018 at 07:19:03PM -0700, Randy Dunlap wrote:
> Date: Sun, 2 Sep 2018 19:19:03 -0700
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> To: Kenneth Lee <nek.in.cn@xxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>,
>  Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, "David S . Miller"
>  <davem@xxxxxxxxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>, Alex Williamson
>  <alex.williamson@xxxxxxxxxx>, Kenneth Lee <liguozhu@xxxxxxxxxxxxx>, Hao
>  Fang <fanghao11@xxxxxxxxxx>, Zhou Wang <wangzhou1@xxxxxxxxxxxxx>, Zaibo Xu
>  <xuzaibo@xxxxxxxxxx>, Philippe Ombredanne <pombredanne@xxxxxxxx>, Greg
>  Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Thomas Gleixner
>  <tglx@xxxxxxxxxxxxx>, linux-doc@xxxxxxxxxxxxxxx,
>  linux-kernel@xxxxxxxxxxxxxxx, linux-crypto@xxxxxxxxxxxxxxx,
>  iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx,
>  linux-accelerators@xxxxxxxxxxxxxxxx, Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>,
>  Sanjay Kumar <sanjay.k.kumar@xxxxxxxxx>
> CC: linuxarm@xxxxxxxxxx
> Subject: Re: [PATCH 6/7] crypto: add sdmdev support to Hisilicon QM
> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
>  Thunderbird/52.9.1
> Message-ID: <46e57b2b-756e-e256-5b3c-30749d865512@xxxxxxxxxxxxx>
> 
> On 09/02/2018 05:52 PM, Kenneth Lee wrote:
> > diff --git a/drivers/crypto/hisilicon/Kconfig b/drivers/crypto/hisilicon/Kconfig
> > index 1d155708cd69..b85fab48fdab 100644
> > --- a/drivers/crypto/hisilicon/Kconfig
> > +++ b/drivers/crypto/hisilicon/Kconfig
> > @@ -17,6 +17,16 @@ config CRYPTO_DEV_HISI_SEC
> >  	  To compile this as a module, choose M here: the module
> >  	  will be called hisi_sec.
> >  
> > +config CRYPTO_DEV_HISI_SDMDEV
> > +	bool "Enable SDMDEV interface"
> > +	depends on CRYPTO_DEV_HISILICON
> > +	select VFIO_SDMDEV
> > +	help
> > +	  Enable this enable the SDMDEV, "shared IOMMU Domain Mediated Device"
> 
> At a minimum:
> 	  Enable this to enable the SDMDEV,
> 
> although that could be done better.  Maybe just:
> 	  Enable the SDMDEV "shared IOMMU Domain Mediated Device"
> 
> 	  
> > +	  interface for all Hisilicon accelerators if they can. The SDMDEV
> 
> probably drop "if they can":          accelerators.  The SDMDEV interface
> 
> > +	  enable the WarpDrive user space accelerator driver to access the
> 
> 	  enables

Thank you, will change them all in the coming version.

> 
> > +	  hardware function directly.
> > +
> 
> 
> -- 
> ~Randy

-- 
			-Kenneth(Hisilicon)

================================================================================
æéäååéäåæåäååçäåäæïäéäåéçäéååäååçääæççãç
æääåäääääååäçïåæääéäåéæéååæéãååãææåïæéää
çäæãåææéæäæéäïèæçåçèæéäéçåääååéæéäï
This e-mail and its attachments contain confidential information from HUAWEI,
which is intended only for the person or entity whose address is listed above.
Any use of the 
information contained herein in any way (including, but not limited to, total or
partial disclosure, reproduction, or dissemination) by persons other than the
intended 
recipient(s) is prohibited. If you receive this e-mail in error, please notify
the sender by phone or email immediately and delete it!