Re: [PATCH] usb: typec: don't disable sink or source on initialization

[Heikki Krogerus]

+Guenter

On Thu, Sep 06, 2018 at 01:26:44PM -0600, Angus Ainslie (Purism) wrote:
> If the board is being powered by USB disabling the source and sink
> can remove power from the board. Default to source and sink enabled.
> 
> Signed-off-by: Angus Ainslie (Purism) <angus@xxxxxxxx>
> ---
>  drivers/usb/typec/tcpm.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c
> index ca7bedb46f7f..a1b819cf31da 100644
> --- a/drivers/usb/typec/tcpm.c
> +++ b/drivers/usb/typec/tcpm.c
> @@ -2462,9 +2462,11 @@ static int tcpm_init_vbus(struct tcpm_port *port)
>  {
>  	int ret;
>  
> -	ret = port->tcpc->set_vbus(port->tcpc, false, false);
> -	port->vbus_source = false;
> -	port->vbus_charge = false;
> +	/* default to source and sink enabled in case USB is our only power
> +	 * source */
> +	ret = port->tcpc->set_vbus(port->tcpc, true, true);
> +	port->vbus_source = true;
> +	port->vbus_charge = true;
>  	return ret;
>  }

-- 
heikki