Re: [PATCH 09/10] phy: Add Cadence D-PHY support

[Maxime Ripard]

On Wed, Sep 05, 2018 at 04:48:27PM +0300, Laurent Pinchart wrote:
> Hi Maxime,
> 
> Thank you for the patch.
> 
> On Wednesday, 5 September 2018 12:16:40 EEST Maxime Ripard wrote:
> > Cadence has designed a D-PHY that can be used by the, currently in tree,
> > DSI bridge (DRM), CSI Transceiver and CSI Receiver (v4l2) drivers.
> > 
> > Only the DSI driver has an ad-hoc driver for that phy at the moment, while
> > the v4l2 drivers are completely missing any phy support. In order to make
> > that phy support available to all these drivers, without having to
> > duplicate that code three times, let's create a generic phy framework
> > driver.
> > 
> > Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxx>
> > ---
> >  drivers/phy/Kconfig             |   1 +-
> >  drivers/phy/Makefile            |   1 +-
> >  drivers/phy/cadence/Kconfig     |  13 +-
> >  drivers/phy/cadence/Makefile    |   1 +-
> >  drivers/phy/cadence/cdns-dphy.c | 499 +++++++++++++++++++++++++++++++++-
> 
> Should the DT bindings be split from Documentation/devicetree/bindings/
> display/bridge/cdns,dsi.txt ?

Yep, I'll change it.

Thanks!
Maxime

-- 
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Attachment: signature.asc
Description: PGP signature