Re: [tip:x86/paravirt] x86/paravirt: Move the pv_irq_ops under the PARAVIRT_XXL umbrella

[Juergen Gross]

On 07/09/18 16:49, Borislav Petkov wrote:
> Hi JÃrgen,
> 
> On Mon, Sep 03, 2018 at 08:01:40AM -0700, tip-bot for Juergen Gross wrote:
>> Commit-ID:  6da63eb241a05b0e676d68975e793c0521387141
>> Gitweb:     https://git.kernel.org/tip/6da63eb241a05b0e676d68975e793c0521387141
>> Author:     Juergen Gross <jgross@xxxxxxxx>
>> AuthorDate: Tue, 28 Aug 2018 09:40:24 +0200
>> Committer:  Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>> CommitDate: Mon, 3 Sep 2018 16:50:36 +0200
>>
>> x86/paravirt: Move the pv_irq_ops under the PARAVIRT_XXL umbrella
>>
>> All of the paravirt ops defined in pv_irq_ops are for Xen PV guests
>> or VSMP only. Define them only if CONFIG_PARAVIRT_XXL is set.
>>
>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
>> Cc: virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
>> Cc: akataria@xxxxxxxxxx
>> Cc: rusty@xxxxxxxxxxxxxxx
>> Cc: boris.ostrovsky@xxxxxxxxxx
>> Cc: hpa@xxxxxxxxx
>> Link: https://lkml.kernel.org/r/20180828074026.820-14-jgross@xxxxxxxx
>>
>> ---
>>  arch/x86/include/asm/irqflags.h       | 8 +-------
>>  arch/x86/include/asm/paravirt.h       | 6 +++---
>>  arch/x86/include/asm/paravirt_types.h | 3 ++-
>>  arch/x86/kernel/asm-offsets.c         | 2 +-
>>  arch/x86/kernel/asm-offsets_64.c      | 2 +-
>>  arch/x86/kernel/paravirt.c            | 2 +-
>>  arch/x86/kernel/paravirt_patch_32.c   | 4 ++--
>>  arch/x86/kernel/paravirt_patch_64.c   | 4 +++-
>>  arch/x86/kernel/vsmp_64.c             | 2 +-
>>  9 files changed, 15 insertions(+), 18 deletions(-)
> 
> this one is breaking the randconfig builds with the following error
> (failure case simplified):
> 
> $ make arch/x86/entry/entry_64.o
>   DESCEND  objtool
>   CALL    scripts/checksyscalls.sh
>   AS      arch/x86/entry/entry_64.o
> In file included from arch/x86/entry/entry_64.S:33:0:
> ./arch/x86/include/asm/paravirt.h:938:0: warning: "SAVE_FLAGS" redefined
>  #define SAVE_FLAGS(clobbers)                                        \

And the fixing patch is already there:

https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/patch/?id=b7a5eb6aafa95fce45fc4dcbc195cb232fa1b76d


Juergen