Re: [PATCH] infiniband: nes: add unlikely() to assert()

From: Doug Ledford
Date: Fri Sep 07 2018 - 11:13:27 EST


On Wed, 2018-09-05 at 09:01 +0300, Leon Romanovsky wrote:
> On Fri, Aug 31, 2018 at 10:24:18PM +0300, Igor Stoppa wrote:
> > Typically the assert is expected to not fail.
>
> This whole assert can be removed.
>
> >
> > Signed-off-by: Igor Stoppa <igor.stoppa@xxxxxxxxxx>
> > Acked-by: Doug Ledford <dledford@xxxxxxxxxx>
>
> Most probably that I missed discussion, but anyway, does this
> "Acked-by" come from internal or external discussion?

This patch was part of a larger series on lkml. In that context, I
acked it so that the series could be applied by whomever took it (it
didn't belong on rdma-list as a series since only one patch out of some
large number touched rdma files). Now it is being resent as not part of
a series, but my ack was preserved.

--
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

Attachment: signature.asc
Description: This is a digitally signed message part