Re: [PATCH v2 0/3] mtd concat device driver

[Bernhard Frauendienst]

Apologies, again, I seem not to be able to handle git-send-mail
correctly, the cover letter got lost in operation (using get_maintainers
on a cover letter is not a good idea). Here it is again:


Hi everybody,

when porting my router board from a mach-file based OpenWRT target to a
device-tree based target, I found that there is no generic way to create
a mtd_concat device from within the dts. The following patches attempt
to provide that possibility.

This is a second roll of that patch series, the first one can be seen at
[1]. Apologies for not including the correct recipients in the first
roll.

In this first discussion, concerns were raised that a driver for a
"virtual" device like this might have no place in the device tree
system. However, I would argue that this very similar to specifying the
partitions of a mtd device, which can also done in the device tree. In
fact, I believe this is the only way to be able to specify the
partitions of such a concat device in the dts file (but I'm happy to be
corrected if I'm mistaken).
I have made the example in the dt-binding documentation a little bit
more expressive in this detail.

In this second roll I have also addressed all issues that reviewers have
brought up so far, hopefully to their satisfaction.

Best Regards
Bernhard

[1] 
http://lists.infradead.org/pipermail/linux-mtd/2018-September/083832.html


Bernhard Frauendienst (3):
 mtd: core: add get_mtd_device_by_node
 dt-bindings: add bindings for mtd-concat devices
 mtd: mtdconcat: add dt driver for concat devices

Â.../devicetree/bindings/mtd/mtd-concat.txtÂÂÂ |Â 36 +++++
Âdrivers/mtd/KconfigÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 2 +
Âdrivers/mtd/MakefileÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 3 +
Âdrivers/mtd/composite/KconfigÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 12 ++
Âdrivers/mtd/composite/MakefileÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 7 +
Âdrivers/mtd/composite/virt_concat.cÂÂÂÂÂÂÂÂÂÂ | 128 ++++++++++++++++++
Âdrivers/mtd/mtdcore.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 38 ++++++
Âinclude/linux/mtd/mtd.hÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 2 +
Â8 files changed, 228 insertions(+)
Âcreate mode 100644 Documentation/devicetree/bindings/mtd/mtd-concat.txt
Âcreate mode 100644 drivers/mtd/composite/Kconfig
Âcreate mode 100644 drivers/mtd/composite/Makefile
Âcreate mode 100644 drivers/mtd/composite/virt_concat.c

--
2.17.1