RE: [PATCH v3 1/2] net: ethernet: i40e: fix build error

[Keller, Jacob E]

> -----Original Message-----
> From: Wang, Dongsheng [mailto:dongsheng.wang@xxxxxxxxxxxxxxxx]
> Sent: Friday, September 07, 2018 5:41 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@xxxxxxxxx>;
> sergei.shtylyov@xxxxxxxxxxxxxxxxxx
> Cc: Keller, Jacob E <jacob.e.keller@xxxxxxxxx>; davem@xxxxxxxxxxxxx; intel-
> wired-lan@xxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Wyborny, Carolyn <carolyn.wyborny@xxxxxxxxx>
> Subject: Re: [PATCH v3 1/2] net: ethernet: i40e: fix build error
> 
> Hello all,
> 
> The i40e_ethtool_stats.h is just included by i40e/i40e_ethtool.c. So the
> static doesn't make any affect. And Carolyn's team is working rebuild
> i40e and i40evf.
> 
> Cheers,
> Dongsheng

Dave wanted a fix sent to netdev by end of day today. I think the best immediate solution is to just migrate that code back into the i40e_ethtool.c and i40evf_ethtool.c files, rather than only the single function.

I'm going to send that patch to netdev now, since Jeff Kirsher is on vacation.

Thanks,
Jake