Re: [PATCH] ethernet: hnae: add unlikely() to assert()

[Igor Stoppa]

On 08/09/18 00:46, David Miller wrote:
> From: Igor Stoppa <igor.stoppa@xxxxxxxxx>
> Date: Fri,  7 Sep 2018 20:26:50 +0300
>
> > The assert() condition is likely to be true.
>
> Worse than that is that drivers should not be definiting their own
> private "assert()" macro.
>
> I'd rather have that fixed instead.  We have tons of standard kernel
> facilities that do what they are trying to do here, without overloading
> the standard C namespace in this way.

I've converted into WARN() what passed the compile test.
In one case it didn't even compile :-(

I could only compile-test.

--
igor