Re: [PATCH] bcache: remove redundant condition before debugfs_remove
From: Junhui Tang
Date: Sun Sep 09 2018 - 22:45:46 EST
LGTM
Reviewed-by: tang.junhui.linux@xxxxxxxxx
zhong jiang <zhongjiang@xxxxxxxxxx> ä2018å9æ8æåå äå9:08åéï
>
> debugfs_remove has taken the IS_ERR_OR_NULL into account. Just
> remove the unnecessary condition.
>
> Signed-off-by: zhong jiang <zhongjiang@xxxxxxxxxx>
> ---
> drivers/md/bcache/super.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index 2d26f9e..a3d2a94 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -1506,8 +1506,7 @@ static void cache_set_free(struct closure *cl)
> struct cache *ca;
> unsigned int i;
>
> - if (!IS_ERR_OR_NULL(c->debug))
> - debugfs_remove(c->debug);
> + debugfs_remove(c->debug);
>
> bch_open_buckets_free(c);
> bch_btree_cache_free(c);
> --
> 1.7.12.4
>