Re: [PATCH] uio: convert to vm_fault_t

[Souptick Joarder]

On Sat, Sep 1, 2018 at 10:25 PM Souptick Joarder <jrdr.linux@xxxxxxxxx> wrote:
>
> As part of commit 9b85e95a3080 ("uio: Change return
> type to vm_fault_t") in 4.19-rc1, this conversion
> was missed. Now converted 'ret' to vm_fault_t type.

Greg, this was missed. Yes, this is not a regression fix,
but can we get this patch in 4.19-rc-X else it might go untraced
and later generate compile error when actual vm_fault_t will be
introduced ?

>
> Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx>
> ---
>  drivers/uio/uio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
> index 70a7981..8fae1a4 100644
> --- a/drivers/uio/uio.c
> +++ b/drivers/uio/uio.c
> @@ -668,7 +668,7 @@ static vm_fault_t uio_vma_fault(struct vm_fault *vmf)
>         struct page *page;
>         unsigned long offset;
>         void *addr;
> -       int ret = 0;
> +       vm_fault_t ret = 0;
>         int mi;
>
>         mutex_lock(&idev->info_lock);
> --
> 1.9.1
>