Re: [PATCH v3 10/12] RISC-V: Add logical CPU indexing for RISC-V

From: Christoph Hellwig
Date: Mon Sep 10 2018 - 07:28:09 EST


On Thu, Sep 06, 2018 at 01:05:33AM -0700, Atish Patra wrote:
> Currently, both linux cpu id and hardware cpu id are same.
> This is not recommended as it will lead to discontinuous cpu
> indexing in Linux. Moreover, kdump kernel will run from CPU0
> which would be absent if we follow existing scheme.
>
> Implement a logical mapping between Linux cpu id and hardware
> cpuid to decouple these two. Always mark the boot processor as
> cpu0 and all other cpus get the logical cpu id based on their
> booting order.
>
> Signed-off-by: Atish Patra <atish.patra@xxxxxxx>
> Reviewed-by : Anup Patel <anup@xxxxxxxxxxxxxx>

drop the two spaces before the ":", please.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>