Re: [PATCH v3 2/3] dt-bindings: add bindings for mtd-concat devices

[Bernhard Frauendienst]

Am 10.09.2018 um 12:51 schrieb RafaÅ MiÅecki:
> On Sat, 8 Sep 2018 at 15:14, Bernhard Frauendienst  > <kernel@xxxxxxxxxxxxxxxxx> wrote: >> >> Document virtual mtd-concat 
device bindings. >> >> Signed-off-by: Bernhard Frauendienst 
<kernel@xxxxxxxxxxxxxxxxx> >> --- >> 
.../devicetree/bindings/mtd/mtd-concat.txt | 36 +++++++++++++++++++ >> 1 
file changed, 36 insertions(+) >> create mode 100644 
Documentation/devicetree/bindings/mtd/mtd-concat.txt >> >> diff --git 
a/Documentation/devicetree/bindings/mtd/mtd-concat.txt 
b/Documentation/devicetree/bindings/mtd/mtd-concat.txt >> new file mode 
100644 >> index 000000000000..2daf3157b163 >> --- /dev/null >> +++ 
b/Documentation/devicetree/bindings/mtd/mtd-concat.txt >> @@ -0,0 +1,36 
@@ >> +Virtual MTD concat device > > I think you forgot to include the 
documentation. Please ***describe*** > that binding.
You are right, I'm afraid I was mislead by some of the rather sparse
documentation files in the mtd directory.
Would something along these lines be sufficient?

--snip--
Virtual MTD concat device

A virtual composite device that concatenates multiple child devices into a
single mtd device. The child mtd nodes must also be defined in the tree and
are referenced using phandles.

Required properties:
- compatible : must be "mtd-concat"
- devices : list of phandles to mtd nodes in the order they should be
ÂÂÂ ÂÂÂ concatenated

The device tree may optionally contain sub-nodes describing partitions 
of the
address space. See partition.txt for more detail.


Example:
--snip--

Regards,
Bernhard