Re: [PATCH v2] asm-generic: bug: unify hints for BUG_ON()

From: Arnd Bergmann
Date: Mon Sep 10 2018 - 08:17:11 EST


On Sat, Sep 8, 2018 at 6:59 AM Igor Stoppa <igor.stoppa@xxxxxxxxx> wrote:
>
> If BUG_ON() is used instead of BUG(), it means that probably the
> preferred outcome is to not BUG(), therefore the condition tested should
> be unlikely().
>
> However, when CONFIG_PROFILE_ANNOTATED_BRANCHES is enabled, the hint is
> disabled, to avoid generating false-positive warnings caused by
> -Wmaybe-uninitialized.
>
> Signed-off-by: Igor Stoppa <igor.stoppa@xxxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: linux-arch@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> ---

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>

I assume this will be included in a longer patch series rather than
going through
my asm-generic tree, right?

Arnd