Re: [RFC PATCH linux-next] btrfs: btrfs_run_delayed_refs_for_head() can be static

From: David Sterba
Date: Mon Sep 10 2018 - 12:49:06 EST


On Mon, Sep 10, 2018 at 11:00:29PM +0800, kbuild test robot wrote:
>
> Fixes: ac75a14eb672 ("btrfs: Factor out loop processing all refs of a head")
> Signed-off-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
> ---
> extent-tree.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
> index b0882b6..719f1bb 100644
> --- a/fs/btrfs/extent-tree.c
> +++ b/fs/btrfs/extent-tree.c
> @@ -2537,9 +2537,9 @@ struct btrfs_delayed_ref_head *btrfs_obtain_ref_head(
> }
>
> STATIC
> -int btrfs_run_delayed_refs_for_head(struct btrfs_trans_handle *trans,
> - struct btrfs_delayed_ref_head *locked_ref,
> - unsigned long *run_refs)
> +static int btrfs_run_delayed_refs_for_head(struct btrfs_trans_handle *trans,
> + struct btrfs_delayed_ref_head *locked_ref,
> + unsigned long *run_refs)

I have a cleanup series to get rid of the STATIC macro, will result in
normal 'static' of the function. The patch will need to be updated, you
can ignore the warning for now.

> {
> struct btrfs_fs_info *fs_info = trans->fs_info;
> struct btrfs_delayed_ref_root *delayed_refs;