RE: [PATCH] Drivers: hv: vmbus: include header for get_irq_regs()

From: KY Srinivasan
Date: Mon Sep 10 2018 - 17:08:50 EST




> -----Original Message-----
> From: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> Sent: Monday, September 10, 2018 7:07 AM
> To: KY Srinivasan <kys@xxxxxxxxxxxxx>; Haiyang Zhang
> <haiyangz@xxxxxxxxxxxxx>; Stephen Hemminger
> <sthemmin@xxxxxxxxxxxxx>
> Cc: devel@xxxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Steven
> Rostedt <rostedt@xxxxxxxxxxx>; Bernhard Landauer
> <oberon@xxxxxxxxxxx>; Ralf Ramsauer <ralf.ramsauer@oth-
> regensburg.de>
> Subject: Re: [PATCH] Drivers: hv: vmbus: include header for get_irq_regs()
>
> On 2018-08-30 09:55:03 [+0200], To K. Y. Srinivasan wrote:
> > On !RT the header file get_irq_regs() gets pulled in via other header files.
> On
> > RT it does not and the build fails:
> >
> > drivers/hv/vmbus_drv.c:975 implicit declaration of function
> âget_irq_regsâ [-Werror=implicit-function-declaration]
> > drivers/hv/hv.c:115 implicit declaration of function âget_irq_regsâ [-
> Werror=implicit-function-declaration]
> >
> > Add the header file for get_irq_regs() in a common header so it used by
> > vmbus_drv.c by hv.c for their get_irq_regs() usage.
> >
> > Reported-by: Bernhard Landauer <oberon@xxxxxxxxxxx>
> > Reported-by: Ralf Ramsauer <ralf.ramsauer@xxxxxxxxxxxxxxxxx>
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
>
> ping

It is in my queue; will submit it soon.

K. Y
>
> > ---
> > drivers/hv/hyperv_vmbus.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h
> > index 72eaba3d50fc2..797f07918197c 100644
> > --- a/drivers/hv/hyperv_vmbus.h
> > +++ b/drivers/hv/hyperv_vmbus.h
> > @@ -31,6 +31,7 @@
> > #include <linux/atomic.h>
> > #include <linux/hyperv.h>
> > #include <linux/interrupt.h>
> > +#include <linux/irq.h>
> >
> > #include "hv_trace.h"
> >
> > --
> > 2.18.0
> >