RE: [PATCH] xen-netback: remove unecessary condition check before debugfs_remove_recursive

[Paul Durrant]

> -----Original Message-----
> From: zhong jiang [mailto:zhongjiang@xxxxxxxxxx]
> Sent: 08 September 2018 14:54
> To: davem@xxxxxxxxxxxxx; Paul Durrant <Paul.Durrant@xxxxxxxxxx>; Wei Liu
> <wei.liu2@xxxxxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH] xen-netback: remove unecessary condition check before
> debugfs_remove_recursive
> 
> debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just
> remove the condition check before debugfs_remove_recursive.
> 
> Signed-off-by: zhong jiang <zhongjiang@xxxxxxxxxx>

Reviewed-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

> ---
>  drivers/net/xen-netback/netback.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-
> netback/netback.c
> index 3621e05..80aae3a 100644
> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -1660,8 +1660,7 @@ static int __init netback_init(void)
>  static void __exit netback_fini(void)
>  {
>  #ifdef CONFIG_DEBUG_FS
> -	if (!IS_ERR_OR_NULL(xen_netback_dbg_root))
> -		debugfs_remove_recursive(xen_netback_dbg_root);
> +	debugfs_remove_recursive(xen_netback_dbg_root);
>  #endif /* CONFIG_DEBUG_FS */
>  	xenvif_xenbus_fini();
>  }
> --
> 1.7.12.4