Re: [for -stable] commit "c82919888064 ath10k: fix scan crash due to incorrect length calculation"

From: Kalle Valo
Date: Tue Sep 11 2018 - 10:47:39 EST


Brian Norris <briannorris@xxxxxxxxxxxx> writes:

> Hi Greg / stable maintainer(s),
>
> IIUC, this commit is a good candidate for -stable. I just hit the bug on
> 4.14, because of new vendor firmware that noticed the mismatched length
> (an internal "assert"), but it seems like this is equally problematic
> from the kernel side for as long as this code existed [1]:
>
> commit c8291988806407e02a01b4b15b4504eafbcc04e0
> Author: Zhi Chen <zhichen@xxxxxxxxxxxxxx>
> Date: Mon Jun 18 17:00:39 2018 +0300
>
> ath10k: fix scan crash due to incorrect length calculation
>
> Thanks,
> Brian
>
> [1] I guess that would be:
>
> Fixes: ca996ec56608 ("ath10k: implement wmi-tlv backend")
>
> which was in v4.0.

FWIW:

Acked-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx>

Thanks Brian!

--
Kalle Valo