Re: [PATCH v2 11/13] udmabuf: drop WARN_ON() check.

From: Laurent Pinchart
Date: Tue Sep 11 2018 - 11:07:02 EST


Hi Gerd,

Thank you for the patch.

On Tuesday, 11 September 2018 16:42:14 EEST Gerd Hoffmann wrote:

Still no commit message ? :-)

> Reported-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Signed-off-by: Gerd Hoffmann <kraxel@xxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
> drivers/dma-buf/udmabuf.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
> index b637a8be6d..7a4fd2194d 100644
> --- a/drivers/dma-buf/udmabuf.c
> +++ b/drivers/dma-buf/udmabuf.c
> @@ -25,9 +25,6 @@ static int udmabuf_vm_fault(struct vm_fault *vmf)
> struct vm_area_struct *vma = vmf->vma;
> struct udmabuf *ubuf = vma->vm_private_data;
>
> - if (WARN_ON(vmf->pgoff >= ubuf->pagecount))
> - return VM_FAULT_SIGBUS;
> -
> vmf->page = ubuf->pages[vmf->pgoff];
> get_page(vmf->page);
> return 0;


--
Regards,

Laurent Pinchart