Re: [PATCH 4.4 22/79] Smack: Mark inode instant in smack_task_to_inode

[Ben Hutchings]

On Thu, 2018-08-23 at 09:52 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.ÂÂIf anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Casey Schaufler <casey@xxxxxxxxxxxxxxxx>
> 
> [ Upstream commit 7b4e88434c4e7982fb053c49657e1c8bbb8692d9 ]
> 
> Smack: Mark inode instant in smack_task_to_inode
> 
> /proc clean-up in commit 1bbc55131e59bd099fdc568d3aa0b42634dbd188

That change ("/proc clean-up") only went into 4.18 and hasn't been
backported to stable, so does this make sense for earlier stable
branches?

Ben.

> resulted in smack_task_to_inode() being called before smack_d_instantiate.
> This resulted in the smk_inode value being ignored, even while present
> for files in /proc/self. Marking the inode as instant here fixes that.
> 
> Signed-off-by: Casey Schaufler <casey@xxxxxxxxxxxxxxxx>
> Signed-off-by: James Morris <james.morris@xxxxxxxxxxxxx>
> Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
> Âsecurity/smack/smack_lsm.c |ÂÂÂÂ1 +
> Â1 file changed, 1 insertion(+)
> 
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -2260,6 +2260,7 @@ static void smack_task_to_inode(struct t
> Â	struct smack_known *skp = smk_of_task_struct(p);
> Â
> Â	isp->smk_inode = skp;
> +	isp->smk_flags |= SMK_INODE_INSTANT;
> Â}
> Â
> Â/*
> 
> 
> 
-- 
Ben Hutchings, Software Developer                Â        Codethink Ltd
https://www.codethink.co.uk/                 Dale House, 35 Dale Street
                                     Manchester, M1 2HF, United Kingdom