Re: [PATCH net-next v3 17/17] net: WireGuard secure network tunnel

From: Jason A. Donenfeld
Date: Tue Sep 11 2018 - 17:11:40 EST


Hello Andrew,

On Tue, Sep 11, 2018 at 7:30 AM Andrew Lunn <andrew@xxxxxxx> wrote:
> I don't know if any of the crypto people are reviewing the networking
> code, but i don't think there are many networking people reviewing the
> crypto code.
>
> So please can you put the change log between versions for the
> networking code here, where we can easily see it.

All submissions >v1 have had a changelog in the 00/17 commit.

> I see you have yet again completely ignored my request to either
> 1) Remove the inline
> 2) Argue why it should be kept.

Most uses of inline are this way after checking the compiler output on
several platforms. (Generally my build-run-test cycle is actually
build-IDAPro-run-test.) If you feel that's been done too liberally,
I'm happy to spend time rechecking each use case.