Re: [PATCH v3 2/4] fs: Don't need to put list_lru into its own cacheline

From: Dave Chinner
Date: Tue Sep 11 2018 - 18:02:51 EST


On Tue, Sep 11, 2018 at 03:18:24PM -0400, Waiman Long wrote:
> The list_lru structure is essentially just a pointer to a table of
> per-node LRU lists. Even if CONFIG_MEMCG_KMEM is defined, the list
> field is just used for LRU list registration and shrinker_id is set
> at initialization. Those fields won't need to be touched that often.
>
> So there is no point to make the list_lru structures to sit in their
> own cachelines.
>
> Signed-off-by: Waiman Long <longman@xxxxxxxxxx>

Looks fine.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
--
Dave Chinner
david@xxxxxxxxxxxxx