Re: [PATCH] rsxx: Remove unnecessary parentheses

From: Jens Axboe
Date: Tue Sep 11 2018 - 18:57:41 EST


On 9/11/18 3:50 PM, Nathan Chancellor wrote:
> Clang warns when more than one set of parentheses is used for a
> single conditional statement:
>
> drivers/block/rsxx/cregs.c:279:15: warning: equality comparison with
> extraneous parentheses [-Wparentheses-equality]
> if ((cmd->op == CREG_OP_READ)) {
> ~~~~~~~~^~~~~~~~~~~~~~~
> drivers/block/rsxx/cregs.c:279:15: note: remove extraneous parentheses
> around the comparison to silence this warning
> if ((cmd->op == CREG_OP_READ)) {
> ~ ^ ~
> drivers/block/rsxx/cregs.c:279:15: note: use '=' to turn this equality
> comparison into an assignment
> if ((cmd->op == CREG_OP_READ)) {
> ^~
> =
> 1 warning generated.

Applied for 4.20, thanks.

--
Jens Axboe