Re: [PATCH] net: ipv4: Use BUG_ON directly instead of a if condition followed by BUG

From: David Miller
Date: Wed Sep 12 2018 - 02:54:21 EST


From: zhong jiang <zhongjiang@xxxxxxxxxx>
Date: Mon, 10 Sep 2018 22:38:02 +0800

> The if condition can be removed if we use BUG_ON directly.
> The issule is detected with the help of Coccinelle.
>
> Signed-off-by: zhong jiang <zhongjiang@xxxxxxxxxx>

You keep asking if this is worthy to do.

I think the most worthy thing to do is actually build test your
patches.