Re: [linux-sunxi] Re: [PATCH 02/27] arm64: allwinner: h6: add system controller device tree node

[Icenowy Zheng]

ä 2018å9æ12æ GMT+08:00 äå10:49:12, Chen-Yu Tsai <wens@xxxxxxxx> åå:
>On Tue, Sep 4, 2018 at 4:44 PM Icenowy Zheng <icenowy@xxxxxxx> wrote:
>>
>>
>>
>> ä 2018å9æ4æ GMT+08:00 äå4:40:56, Chen-Yu Tsai <wens@xxxxxxxx> åå:
>> >On Sun, Sep 2, 2018 at 3:27 PM Jernej Skrabec
><jernej.skrabec@xxxxxxxx>
>> >wrote:
>> >>
>> >> From: Icenowy Zheng <icenowy@xxxxxxx>
>> >>
>> >> As we have already binding for the H6 system controller, add its
>node
>> >> to the device tree.
>> >>
>> >> Signed-off-by: Icenowy Zheng <icenowy@xxxxxxx>
>> >> [fixed compatible string]
>> >> Signed-off-by: Jernej Skrabec <jernej.skrabec@xxxxxxxx>
>> >
>> >Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxx>
>>
>> By the way can these patches be applied first? (patches
>> related to syscon).
>>
>> They're also needed for EMAC.
>
>Applied.
>
>BTW, the H6 system control EMAC register also has the internal PHY
>related controls seen on H3/H5. IIRC you previously mentioned that
>they have no effect?

Yes, because the "internal PHY" on H6 is on AC200.

The internal/external mux bit has effect (although it will mux
to a non-existent PHY when switching to "internal", render
EMAC not usable), but it also has effect on A64 (same effect
with H6), on which it's not documented.

>
>ChenYu
>
>_______________________________________________
>linux-arm-kernel mailing list
>linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>http://lists.infradead.org/mailman/listinfo/linux-arm-kernel