Re: [PATCH v2 1/3] Revert "ASoC: Intel: Skylake: Acquire irq after RIRB allocation"

[Yu Zhao]

On Wed, Sep 12, 2018 at 11:20:20AM +0100, Mark Brown wrote:
> On Tue, Sep 11, 2018 at 03:12:46PM -0600, Yu Zhao wrote:
> > This reverts commit 12eeeb4f4733bbc4481d01df35933fc15beb8b19.
> > 
> > The patch doesn't fix accessing memory with null pointer in
> > skl_interrupt().
> 
> Please use normal subject lines and so on even for revert patches -
> they're patches just the same as any other.

Well, they seem pretty normal to me, and have been used by many:

  commit 82ab86e82911107ead6fc7cd73568f75bc266a57
  Author: Mark Brown <broonie@xxxxxxxxxx>
  Date:   Mon Oct 30 19:40:25 2017 +0000
  
      Revert "ASoC: rt5651: Enable jack detection on JD* pins"
      
      This reverts commit 60d5a1a47b9a8381c08d2263b11ac9c757c87746.
      
      Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>

Anyway, I'll update them in v3.