Re: [PATCH 4.19 regression fix] printk: For early boot messages check loglevel when flushing the buffer

[Sergey Senozhatsky]

On (09/12/18 15:33), Petr Mladek wrote:
> >  	console_trylock();
> >  	console_may_schedule = 0;
> > +	if (exclusive_console) {
> > +		exclusive_console = NULL;
> > +		console_seq = rollback_console_seq;
> 
> This might be controversial. Yes, it might help in some situations
> (slow exclusive console). But it might be counterproductive
> when the exclusive console is the one that is readable
> after the crash, used for debugging and this change causes
> an incomplete log.

Well, OK. We still print oops messages, just get to this point sooner.

> I would do this change only when people complains about
> the current behavior.

OK. Agreed.

> I think that more important is to do:
[..]
> IMHO, this is a clear win. It fixes a clear mistake.
> 
> I would just rename the variable to exclusive_console_seq_stop or so.

OK. Send a patch.

Reported-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
Acked-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>


	-ss