Re: [PATCH 2/3] mips: Add system call table generation support

[Arnd Bergmann]

On Fri, Sep 14, 2018 at 10:39 AM Firoz Khan <firoz.khan@xxxxxxxxxx> wrote:
>
> The system call tables are in different format in all
> architecture and it will be difficult to manually add or
> modify the system calls in the respective files. To make
> it easy by keeping a script and which'll generate the
> header file and syscall table file so this change will
> unify them across all architectures.
>
> The system call table generation script is added in
> syscalls directory which contain the script to generate
> both uapi header file system call table generation file
> and syscall_32/64.tbl file which'll be the input for the
> scripts.

I think it would be best to name the files
o32/n64/n32 instead of 32/64/n32

It would also be helpful to mention why the n32/n64
files cannot be combined into one nfile here.


> +364     32      pkey_alloc                      sys_pkey_alloc
> +365     32      pkey_free                       sys_pkey_free
> +366     32      statx                           sys_statx

You missed the additon of rseq and io_pgetevetns here.

       Arnd