Re: [PATCH] misc: sgi-gru: fix fall-through annotations

From: Dimitri Sivanich
Date: Fri Sep 14 2018 - 08:43:38 EST


Acked-by: Dimitri Sivanich <sivanich@xxxxxxx>

On Thu, Sep 13, 2018 at 01:53:18PM -0500, Gustavo A. R. Silva wrote:
> Replace "fallthru" with a proper "fall through" annotation.
>
> This fix is part of the ongoing efforts to enabling
> -Wimplicit-fallthrough
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> ---
> drivers/misc/sgi-gru/grukservices.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/sgi-gru/grukservices.c b/drivers/misc/sgi-gru/grukservices.c
> index 0307690..4b23d58 100644
> --- a/drivers/misc/sgi-gru/grukservices.c
> +++ b/drivers/misc/sgi-gru/grukservices.c
> @@ -634,7 +634,7 @@ static int send_noop_message(void *cb, struct gru_message_queue_desc *mqd,
> break;
> case CBSS_PAGE_OVERFLOW:
> STAT(mesq_noop_page_overflow);
> - /* fallthru */
> + /* fall through */
> default:
> BUG();
> }
> @@ -792,7 +792,7 @@ static int send_message_failure(void *cb, struct gru_message_queue_desc *mqd,
> break;
> case CBSS_PAGE_OVERFLOW:
> STAT(mesq_page_overflow);
> - /* fallthru */
> + /* fall through */
> default:
> BUG();
> }
> --
> 2.7.4
>