Re: [RFC][PATCH 02/11] asm-generic/tlb: Provide HAVE_MMU_GATHER_PAGE_SIZE
From: Will Deacon
Date: Fri Sep 14 2018 - 12:56:30 EST
On Thu, Sep 13, 2018 at 11:21:12AM +0200, Peter Zijlstra wrote:
> Move the mmu_gather::page_size things into the generic code instead of
> powerpc specific bits.
>
> Cc: Will Deacon <will.deacon@xxxxxxx>
> Cc: "Aneesh Kumar K.V" <aneesh.kumar@xxxxxxxxxxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Nick Piggin <npiggin@xxxxxxxxx>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
> ---
> arch/Kconfig | 3 +++
> arch/arm/include/asm/tlb.h | 3 +--
> arch/ia64/include/asm/tlb.h | 3 +--
> arch/powerpc/Kconfig | 1 +
> arch/powerpc/include/asm/tlb.h | 17 -----------------
> arch/s390/include/asm/tlb.h | 4 +---
> arch/sh/include/asm/tlb.h | 4 +---
> arch/um/include/asm/tlb.h | 4 +---
> include/asm-generic/tlb.h | 25 +++++++++++++------------
> mm/huge_memory.c | 4 ++--
> mm/hugetlb.c | 2 +-
> mm/madvise.c | 2 +-
> mm/memory.c | 4 ++--
> mm/mmu_gather.c | 5 +++++
> 14 files changed, 33 insertions(+), 48 deletions(-)
Looks fine to me, but I hope we can remove this option altogether in future:
Acked-by: Will Deacon <will.deacon@xxxxxxx>
Will