Re: [PATCH v2] mips: switch to NO_BOOTMEM
From: Paul Burton
Date: Fri Sep 14 2018 - 15:55:16 EST
Hi Mike,
On Mon, Sep 10, 2018 at 12:23:18PM +0300, Mike Rapoport wrote:
> MIPS already has memblock support and all the memory is already registered
> with it.
>
> This patch replaces bootmem memory reservations with memblock ones and
> removes the bootmem initialization.
>
> Since memblock allocates memory in top-down mode, we ensure that memblock
> limit is max_low_pfn to prevent allocations from the high memory.
>
> To have the exceptions base in the lower 512M of the physical memory, its
> allocation in arch/mips/kernel/traps.c::traps_init() is using bottom-up
> mode.
>
> Signed-off-by: Mike Rapoport <rppt@xxxxxxxxxxxxxxxxxx>
> ---
> v2:
> * set memblock limit to max_low_pfn to avoid allocation attempts from high
> memory
> * use boottom-up mode for allocation of the exceptions base
>
> Build tested with *_defconfig.
> Boot tested with qemu-system-mips64el for 32r6el, 64r6el and fuloong2e
> defconfigs.
> Boot tested with qemu-system-mipsel for malta defconfig.
>
> arch/mips/Kconfig | 1 +
> arch/mips/kernel/setup.c | 99 ++++++++--------------------------
> arch/mips/kernel/traps.c | 3 ++
> arch/mips/loongson64/loongson-3/numa.c | 34 ++++++------
> arch/mips/sgi-ip27/ip27-memory.c | 11 ++--
> 5 files changed, 46 insertions(+), 102 deletions(-)
Thanks - applied to mips-next for 4.20.
Apologies for the delay, my son decided to be born a few weeks early &
scupper my plans :)
Paul