Re: [PATCH] net/mlx4_core: print firmware version during driver loading

From: David Miller
Date: Fri Sep 14 2018 - 17:09:13 EST


From: Qing Huang <qing.huang@xxxxxxxxxx>
Date: Fri, 14 Sep 2018 10:15:48 -0700

> IMHO, this information is very useful and only takes up very little
> log file space. :-)

If it's critical then the log is the wrong place for it as the log
is lossy.

The proper place to obtain this information is via the fw_version
field of the ethtool_drvinfo struct. This can be obtained at any time
and is reliable. And if it isn't reliable or correct, we must fix
that.